feat: choose trigger match type #30883

pauldambra · 2025-04-07T14:53:12Z

trigger matching grew organically and isn't clear to customers (or us!)

let's make it an explicit setting so people can choose

pairs with a nice sauvignon blanc or PostHog/posthog-js#1875

flag off

flag on

greptile-apps

PR Summary

This PR removes the obsolete SessionRecordingIngestionSettings component and introduces an explicit trigger match type setting for session recordings, streamlining the UI and backend configuration.

Removed the SessionRecordingIngestionSettings.tsx and its ingestion controls, consolidating settings.
Added the TriggerMatchChoice component in ReplayTriggers.tsx to allow users to choose between 'all' and 'any' trigger matching.
Updated teamActivityDescriber.tsx to describe trigger match type changes.
Enhanced /decide API and remote_config payload with the new triggerMatchType field.
Added migration 0705_add_trigger_match_type.py to include the new field in the Team model.

_{12 file(s) reviewed, 1 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

posthog/api/test/test_decide.py

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

posthog-bot · 2025-04-07T20:34:24Z

📸 UI snapshots have been updated

17 snapshot changes in total. 0 added, 17 modified, 0 deleted:

chromium: 0 added, 17 modified, 0 deleted (diff for shard 1, diff for shard 8)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-04-07T20:43:39Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 5)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-04-07T20:52:31Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 5)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

github-actions · 2025-04-07T21:02:41Z

Size Change: +256 B (0%)

Total Size: 13.2 MB

ℹ️ View Unchanged

Filename	Size	Change
`frontend/dist/toolbar.js`	13.2 MB	+256 B (0%)

_{compressed-size-action}

posthog-bot · 2025-04-08T13:58:25Z

📸 UI snapshots have been updated

16 snapshot changes in total. 0 added, 16 modified, 0 deleted:

chromium: 0 added, 16 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-04-08T14:07:32Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 5)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-04-08T14:16:46Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 5)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-04-08T15:02:18Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-04-09T13:21:35Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-04-09T13:40:01Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 5)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-04-09T13:49:32Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 5)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-04-09T13:58:56Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 5)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-04-09T14:08:06Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 5)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-04-10T09:30:17Z

📸 UI snapshots have been updated

16 snapshot changes in total. 0 added, 16 modified, 0 deleted:

chromium: 0 added, 16 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

feat: choose trigger match type

c3a44b8

greptile-apps bot reviewed Apr 7, 2025

View reviewed changes

posthog/api/test/test_decide.py Outdated Show resolved Hide resolved

pauldambra and others added 5 commits April 7, 2025 16:21

Update posthog/api/test/test_decide.py

daba0e4

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

fix

440c478

Merge branch 'master' into feat/choose-trigger-match-type

2a13036

Update UI snapshots for chromium (8)

04e1b83

Update UI snapshots for chromium (1)

5286ffe

github-actions bot added 3 commits April 7, 2025 20:38

Update query snapshots

a44c311

Update query snapshots

080181c

Update UI snapshots for chromium (5)

3120ae5

Update UI snapshots for chromium (5)

7c657c6

Merge branch 'master' into feat/choose-trigger-match-type

cb620e7

pauldambra requested review from a team, sortafreel and veryayskiy and removed request for a team April 8, 2025 13:56

Update UI snapshots for chromium (1)

5988212

github-actions bot added 2 commits April 8, 2025 14:03

Update query snapshots

012a746

Update UI snapshots for chromium (5)

6e4ccd7

Update UI snapshots for chromium (5)

df9bf23

pauldambra and others added 2 commits April 8, 2025 15:50

fix

86791cc

Update UI snapshots for chromium (1)

0768658

pauldambra added 2 commits April 8, 2025 19:54

Merge branch 'master' into feat/choose-trigger-match-type

a1a39e4

Merge branch 'master' into feat/choose-trigger-match-type

83fcae7

pauldambra enabled auto-merge (squash) April 9, 2025 13:20

Update UI snapshots for chromium (1)

3f126f4

github-actions bot added 2 commits April 9, 2025 13:25

Update query snapshots

3fac9cb

Update UI snapshots for chromium (5)

3820a02

Update UI snapshots for chromium (5)

7cfd59b

Update UI snapshots for chromium (5)

349bf8a

Update UI snapshots for chromium (5)

8dfe428

pauldambra and others added 10 commits April 9, 2025 15:51

fix

e1497e3

fix

be807d0

Update query snapshots

716a0cd

fix

9959802

Update query snapshots

638564c

fix

6599f76

fix

cf49f59

Merge branch 'master' into feat/choose-trigger-match-type

5ffc19f

Merge branch 'master' into feat/choose-trigger-match-type

4c7fd17

Merge branch 'master' into feat/choose-trigger-match-type

ce8d9c6

pauldambra mentioned this pull request Apr 10, 2025

feat: allow ANY or ALL matches for triggers PostHog/posthog-js#1875

Open

Update UI snapshots for chromium (1)

34f720c

Update query snapshots

f3c1dfd

pauldambra merged commit 9682069 into master Apr 10, 2025
110 checks passed

pauldambra deleted the feat/choose-trigger-match-type branch April 10, 2025 10:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: choose trigger match type #30883

feat: choose trigger match type #30883

pauldambra commented Apr 7, 2025 •

edited

Loading

greptile-apps bot left a comment

posthog-bot commented Apr 7, 2025

posthog-bot commented Apr 7, 2025

posthog-bot commented Apr 7, 2025

github-actions bot commented Apr 7, 2025 •

edited

Loading

posthog-bot commented Apr 8, 2025

posthog-bot commented Apr 8, 2025

posthog-bot commented Apr 8, 2025

posthog-bot commented Apr 8, 2025

posthog-bot commented Apr 9, 2025

posthog-bot commented Apr 9, 2025

posthog-bot commented Apr 9, 2025

posthog-bot commented Apr 9, 2025

posthog-bot commented Apr 9, 2025

posthog-bot commented Apr 10, 2025

feat: choose trigger match type #30883

feat: choose trigger match type #30883

Conversation

pauldambra commented Apr 7, 2025 • edited Loading

flag off

flag on

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

posthog-bot commented Apr 7, 2025

📸 UI snapshots have been updated

posthog-bot commented Apr 7, 2025

📸 UI snapshots have been updated

posthog-bot commented Apr 7, 2025

📸 UI snapshots have been updated

github-actions bot commented Apr 7, 2025 • edited Loading

posthog-bot commented Apr 8, 2025

📸 UI snapshots have been updated

posthog-bot commented Apr 8, 2025

📸 UI snapshots have been updated

posthog-bot commented Apr 8, 2025

📸 UI snapshots have been updated

posthog-bot commented Apr 8, 2025

📸 UI snapshots have been updated

posthog-bot commented Apr 9, 2025

📸 UI snapshots have been updated

posthog-bot commented Apr 9, 2025

📸 UI snapshots have been updated

posthog-bot commented Apr 9, 2025

📸 UI snapshots have been updated

posthog-bot commented Apr 9, 2025

📸 UI snapshots have been updated

posthog-bot commented Apr 9, 2025

📸 UI snapshots have been updated

posthog-bot commented Apr 10, 2025

📸 UI snapshots have been updated

pauldambra commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading