feat: add oldest sort option to session replays #30848
Open
+50
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces an "Oldest" sorting option for session recordings, allowing users to view sessions from the beginning of a journey.
- /frontend/src/scenes/session-recordings/playlist/SessionRecordingsPlaylistSettings.tsx: Added new "Oldest" entry and updated label logic via the getLabel helper to handle the 'older' direction.
- /frontend/src/scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic.ts: Enhanced sorting logic by propagating a new 'direction' parameter for proper ordering and pagination.
- /frontend/src/types.ts: Updated type definitions with a new RecordingDirection union to support sorting by 'newer' or 'older'.
💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
pauldambra
reviewed
Apr 5, 2025
frontend/src/scenes/session-recordings/playlist/SessionRecordingsPlaylistSettings.tsx
Outdated
Show resolved
Hide resolved
pauldambra
reviewed
Apr 5, 2025
pauldambra
reviewed
Apr 5, 2025
|
@pauldambra nice. Done! ;D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As described in #30824, there's currently no way to sort session recordings from oldest to newest. This makes it harder to watch sessions in the order they happened. This PR adds an "Oldest" sorting option to make that easier.
Changes
Screenshots
Does this work well for both Cloud and self-hosted?
Yes, it works well for both Cloud and self-hosted deployments.
How did you test this code?