Skip to content

chore(flags): more metrics #30789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

dmarticus
Copy link
Contributor

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added granular timing metrics for more precise flag evaluation performance tracking.

  • Updated rust/feature-flags/src/metrics/metrics_consts.rs to include FLAG_GET_INDIVIDUAL_FLAG_TIME and FLAG_EVALUATE_STATIC_COHORTS_TIME.
  • Modified rust/feature-flags/src/flags/flag_matching.rs to start new timers in the evaluation loop, labeling FLAG_GET_INDIVIDUAL_FLAG_TIME with the flag key.
  • Introduced a new timer for evaluating static cohorts to isolate performance data.
  • Noted potential instrumentation overhead increase; monitor overall performance post-deployment.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@dmarticus dmarticus requested a review from haacked April 4, 2025 02:38
Copy link
Contributor

@haacked haacked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants