-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: improvements for survey stats #30787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR improves survey stats display and filtering by introducing a new stats component with enhanced loading skeletons, conversion rates, and refined user count logic.
frontend/src/scenes/surveys/SurveyResponseFilters.tsx
: Updated header tag for improved accessibility.frontend/src/scenes/surveys/SurveyStatsSummary.tsx
: New component adds proper skeletons and conversion rate display.frontend/src/scenes/surveys/components/StackedBar.tsx
: Implements dynamic response segmentation with tooltips.frontend/src/scenes/surveys/SurveyView.tsx
: Integrates the new stats component.frontend/src/scenes/surveys/surveyLogic.tsx
: Refines user stats to avoid duplicate counts and support conversion rates.
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Size Change: +171 B (0%) Total Size: 13.2 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor comments from me.
@lucasheriques i find a bit odd the |
@marandaneto yes there is a significant number of impressions but no action. it means the survey was displayed (and will be displayed again if the user comes back), but no action was taken if you check our suver here, you'll see that 26% is unanswered (maybe I chan change back to this label instead) |
|
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Problem
right now, we only show responses filtered by user distinct ids. since it's possible on some scenarios a survey is displayed twice, this doesn't track the total number of responses.
Also a chance to improve our loading screens, adding proper skeletons instead of just a random line, and also add the conversion rate for each user.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
yes
How did you test this code?
visual changes only