feat(messaging): add message library with email templates #30783

havenbarnes · 2025-04-03T23:06:23Z

Problem

Adds Messaging library + re-usable emails to messaging platform

Changes

Screenity.video.-.Apr.15.2025.webm

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Added API tests for new backend functionality, working on an Playwright suite in background

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

…dcast-revive

…into broadcast-revive

…into broadcasts-delivery

into broadcasts-logs

…dcasts-logs

…into messaging-campaigns

into messaging-campaigns

havenbarnes · 2025-04-15T21:31:18Z

frontend/src/scenes/pipeline/hogfunctions/hogFunctionConfigurationLogic.tsx

@@ -708,6 +708,9 @@ export const hogFunctionConfigurationLogic = kea<hogFunctionConfigurationLogicTy
        willChangeEnabledOnSave: [
            (s) => [s.configuration, s.hogFunction],
            (configuration, hogFunction) => {
+                if (configuration?.kind === 'messaging_template') {


…aging-library

havenbarnes · 2025-04-15T22:22:19Z

posthog/api/message_templates.py

+    permission_classes = [IsAuthenticated]
+
+    serializer_class = MessageTemplateSerializer
+    queryset = HogFunction.objects.all()


We may just want to make a separate table for this. Originally I figured we'd be making more use of pre-existing HogFunction duplicate/template functionality but we're really just doing hog function name, description, and input copying

Yeah no way this should be a hog function. Hog functions should only be used for things that are actually runnable units of work, otherwise it just becomes a meaningless concept.

…aging-library

greptile-apps

PR Summary

This PR adds a messaging library with reusable email templates to PostHog's messaging platform. Here are the key points about the changes:

Added new API endpoints /messaging/messages and /messaging/templates with corresponding ViewSets for managing email templates and messages
Implemented email template editor with preview/edit modes using EmailEditor component and template selection functionality
Added validation for email template inputs including required fields (from, subject, html) and proper error handling
Created new messaging library UI components including TemplatesTable and MessagesTable for managing templates/messages
Added proper team-based access control and read-only API endpoints with comprehensive test coverage

Key concerns to address:

Template's hog script only prints 'Email template loaded' without actual functionality
Hardcoded values like info@posthog.com and posthog.com links should be configurable
Missing validation for person properties used in template strings
Inconsistent parent query lookup parameters between project_id and team_id in API endpoints
InputsItemSerializer validation gaps for the new email_template type

_{33 file(s) reviewed, 26 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-04-15T22:19:44Z

frontend/src/products.tsx

+    messagingLibraryTemplateFromMessage: (configuration?: object): string =>
+        `/messaging/library/templates/new?#configuration=${encodeURIComponent(JSON.stringify(configuration))}`,


logic: URL hash parameters (#configuration) won't be accessible via normal URL parameter parsing. Consider using a regular query parameter instead.

greptile-apps · 2025-04-15T22:19:45Z

frontend/src/products.tsx

    '/messaging/library': ['MessagingLibrary', 'messagingLibrary'],
-    '/messaging/library/new': ['MessagingLibrary', 'messagingLibraryNew'],
-    '/messaging/library/:id': ['MessagingLibrary', 'messagingLibraryTemplate'],
+    '/messaging/library/templates/:id': ['MessagingLibraryTemplate', 'messagingLibraryTemplate'],


logic: Route pattern '/messaging/library/templates/:id' will match before '/messaging/library/templates/new', which could cause issues with the 'new' template route

greptile-apps · 2025-04-15T22:20:25Z

frontend/src/scenes/pipeline/hogfunctions/email-templater/EmailTemplater.tsx

+                props={props.formLogicProps}
+                formKey={props.formKey}
+            >
+                {(emailMetaFields || ['from', 'to', 'subject']).map((field) => (


style: emailMetaFields fallback could be defined as a constant to avoid recreation on each render

greptile-apps · 2025-04-15T22:21:53Z

posthog/api/message_templates.py

+    def retrieve(self, request: Request, *args, **kwargs):
+        if self.get_object().kind != "messaging_template":
+            return Response(status=status.HTTP_404_NOT_FOUND)
+        return Response(self.get_serializer(self.get_object()).data)


style: Consider adding error handling for get_object() in case object doesn't exist

Suggested change

def retrieve(self, request: Request, *args, **kwargs):

if self.get_object().kind != "messaging_template":

return Response(status=status.HTTP_404_NOT_FOUND)

return Response(self.get_serializer(self.get_object()).data)

def retrieve(self, request: Request, *args, **kwargs):

obj = self.get_object()

if obj.kind != "messaging_template":

return Response(status=status.HTTP_404_NOT_FOUND)

return Response(self.get_serializer(obj).data)

greptile-apps · 2025-04-15T22:21:58Z

posthog/api/__init__.py

+environments_router.register(
+    r"messaging/messages",
+    messages.MessageViewSet,
+    "project_messaging",
+    ["project_id"],
+)


logic: Parent query lookup should be team_id instead of project_id since this is registered on the environments router

Suggested change

environments_router.register(

r"messaging/messages",

messages.MessageViewSet,

"project_messaging",

["project_id"],

)

environments_router.register(

r"messaging/messages",

messages.MessageViewSet,

"project_messaging",

["team_id"],

)

greptile-apps · 2025-04-15T22:24:57Z

products/messaging/frontend/library/TemplatesTable.tsx

+    const { templates, templatesLoading } = useValues(templatesLogic)
+    const { deleteTemplate } = useActions(templatesLogic)
+
+    const columns: LemonTableColumns<Message> = [


style: Table uses Message type but this is a templates table - should define and use a Template type instead for better type safety

greptile-apps · 2025-04-15T22:25:09Z

products/messaging/frontend/library/libraryTemplateLogic.ts

+
+export const libraryTemplateLogic = kea<libraryTemplateLogicType>([
+    path(['products', 'messaging', 'frontend', 'libraryTemplateLogic']),
+    key(({ id }) => id ?? 'unknown'),


logic: Using 'unknown' as fallback for missing ID could lead to key collisions if multiple instances have missing IDs. Consider using a UUID or timestamp-based fallback.

greptile-apps · 2025-04-15T22:25:10Z

products/messaging/frontend/library/libraryTemplateLogic.ts

+                if (!id) {
+                    return []
+                }


logic: Early return with empty array when id is null could cause UI inconsistency. Consider showing at least the base messaging library breadcrumbs.

greptile-apps · 2025-04-15T22:25:27Z

products/messaging/frontend/library/messagesLogic.ts

+    created_at: string | null
+    name: string
+    description: string
+    content: Record<string, any>


style: content field uses Record<string, any> which is too permissive. Consider defining a stricter type for the content structure.

greptile-apps · 2025-04-15T22:25:43Z

products/messaging/manifest.tsx

+        messagingLibraryTemplateFromMessage: (configuration?: object): string =>
+            `/messaging/library/templates/new?#configuration=${encodeURIComponent(JSON.stringify(configuration))}`,


style: Using '#' in query string for configuration may cause issues with URL parsing - consider using regular query parameter

posthog-bot · 2025-04-16T01:13:58Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 5)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

benjackwhite · 2025-04-16T07:10:14Z

posthog/api/message_templates.py

+    permission_classes = [IsAuthenticated]
+
+    serializer_class = MessageTemplateSerializer
+    queryset = HogFunction.objects.all()


Yeah no way this should be a hog function. Hog functions should only be used for things that are actually runnable units of work, otherwise it just becomes a meaningless concept.

benjackwhite · 2025-04-16T07:12:49Z

posthog/api/messages.py

+from posthog.api.shared import UserBasicSerializer
+
+
+class MessageSerializer(serializers.ModelSerializer):


I couldn't see anywhere what this actually is? It sort of just looks like a viewset for filtering hog functions... so why not just use the hog function api?

No reason we can't use hog function API, just wanted to break ground on messaging APIs so that we start building up a cleaner interface around messaging that abstracts away hog function concepts

…aging-library

…into messaging-library

…aging-library

posthog-bot · 2025-04-17T00:31:03Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 5)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…into messaging-library

…aging-library

havenbarnes and others added 30 commits March 31, 2025 11:16

feat(messaging): revive Broadcasts using Integrations

8ee80d4

Update UI snapshots for chromium (1)

feba11e

Merge branch 'master' into broadcast-revive

306dd96

add test for new sendEmail async function

6372f81

Merge branch 'master' into broadcast-revive

6642add

Update posthog/api/integration.py

1db1c81

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update plugin-server/src/cdp/utils/hog-mailjet-request.ts

d90c7f8

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Merge branch 'master' of https://github.com/PostHog/posthog into broa…

e772c6b

…dcast-revive

Merge branch 'broadcast-revive' of https://github.com/PostHog/posthog …

e6ff330

…into broadcast-revive

Merge branch 'broadcast-revive' of https://github.com/PostHog/posthog …

f7fbf70

…into broadcasts-delivery

Merge branch 'master' into broadcast-revive

60fd661

Merge branch 'broadcasts-delivery' of https://github.com/PostHog/posthog

16a9a1e

into broadcasts-logs

Merge branch 'master' of https://github.com/PostHog/posthog into broa…

1f08579

…dcasts-logs

Merge branch 'broadcasts-logs' of https://github.com/PostHog/posthog …

4cc00f7

…into messaging-campaigns

Merge branch 'broadcast-revive' into broadcasts-delivery

5cc647e

Merge branch 'broadcasts-delivery' into broadcasts-logs

2329e4c

Merge branch 'messaging-campaigns' of https://github.com/PostHog/posthog

5cf4468

into messaging-campaigns

Merge branch 'broadcasts-logs' into messaging-campaigns

15093b7

Update UI snapshots for chromium (1)

2e5d6fd

tweak

ed75adc

Update UI snapshots for chromium (2)

7fef4fd

Update UI snapshots for chromium (1)

4a7dd80

Update UI snapshots for chromium (2)

14d54c5

tweak

4dda4bd

Merge branch 'messaging-campaigns' of https://github.com/PostHog/posthog

93335a6

into messaging-campaigns

Update UI snapshots for chromium (1)

b79260a

Update UI snapshots for chromium (1)

83aaecf

Update UI snapshots for chromium (2)

1f98f83

Update UI snapshots for chromium (2)

d8757b3

fix linter

a8e8fb9

template selection

2312f78

havenbarnes changed the title ~~feat(messaging): add API support for message library~~ feat(messaging): add message library with email templates Apr 15, 2025

tweak

1832e4c

havenbarnes commented Apr 15, 2025

View reviewed changes

havenbarnes added 4 commits April 15, 2025 14:43

tweak

4c53992

Merge branch 'master' of https://github.com/PostHog/posthog into mess…

9386263

…aging-library

Merge branch 'master' of https://github.com/PostHog/posthog into mess…

c9c8d8d

…aging-library

add tests for new APIs

e1e803e

havenbarnes marked this pull request as ready for review April 15, 2025 22:19

tweak

86913fe

havenbarnes commented Apr 15, 2025

View reviewed changes

Merge branch 'master' of https://github.com/PostHog/posthog into mess…

2ef8063

…aging-library

greptile-apps bot reviewed Apr 15, 2025

View reviewed changes

github-actions bot and others added 3 commits April 15, 2025 22:31

Update query snapshots

e56964c

Merge branch 'master' into messaging-library

c0ca7ee

Update UI snapshots for chromium (5)

057e80c

benjackwhite requested changes Apr 16, 2025

View reviewed changes

havenbarnes and others added 5 commits April 16, 2025 09:40

Merge branch 'master' of https://github.com/PostHog/posthog into mess…

f635385

…aging-library

de-hogify the message templates

6cd710d

Merge branch 'messaging-library' of https://github.com/PostHog/posthog …

6f7569b

…into messaging-library

Merge branch 'master' of https://github.com/PostHog/posthog into mess…

d674da8

…aging-library

Update UI snapshots for chromium (5)

f200ddf

havenbarnes and others added 6 commits April 16, 2025 17:37

fix tests

3ad9a72

Merge branch 'messaging-library' of https://github.com/PostHog/posthog …

23b2883

…into messaging-library

Update query snapshots

5891fdb

cleanup + fix

a9bfcae

Merge branch 'messaging-library' of https://github.com/PostHog/posthog …

e7b6a3d

…into messaging-library

Merge branch 'master' of https://github.com/PostHog/posthog into mess…

a570958

…aging-library

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(messaging): add message library with email templates #30783

feat(messaging): add message library with email templates #30783

havenbarnes commented Apr 3, 2025 •

edited

Loading

havenbarnes Apr 15, 2025

havenbarnes Apr 15, 2025

benjackwhite Apr 16, 2025

greptile-apps bot left a comment

greptile-apps bot Apr 15, 2025

greptile-apps bot Apr 15, 2025

greptile-apps bot Apr 15, 2025

greptile-apps bot Apr 15, 2025

greptile-apps bot Apr 15, 2025

greptile-apps bot Apr 15, 2025

greptile-apps bot Apr 15, 2025

greptile-apps bot Apr 15, 2025

greptile-apps bot Apr 15, 2025

greptile-apps bot Apr 15, 2025

posthog-bot commented Apr 16, 2025

benjackwhite Apr 16, 2025

benjackwhite Apr 16, 2025

havenbarnes Apr 16, 2025

posthog-bot commented Apr 17, 2025

		messagingLibraryTemplateFromMessage: (configuration?: object): string =>
		`/messaging/library/templates/new?#configuration=${encodeURIComponent(JSON.stringify(configuration))}`,

		from posthog.api.shared import UserBasicSerializer


		class MessageSerializer(serializers.ModelSerializer):

feat(messaging): add message library with email templates #30783

Are you sure you want to change the base?

feat(messaging): add message library with email templates #30783

Conversation

havenbarnes commented Apr 3, 2025 • edited Loading

Problem

Changes

Does this work well for both Cloud and self-hosted?

How did you test this code?

havenbarnes Apr 15, 2025

Choose a reason for hiding this comment

havenbarnes Apr 15, 2025

Choose a reason for hiding this comment

benjackwhite Apr 16, 2025

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Apr 15, 2025

Choose a reason for hiding this comment

greptile-apps bot Apr 15, 2025

Choose a reason for hiding this comment

greptile-apps bot Apr 15, 2025

Choose a reason for hiding this comment

greptile-apps bot Apr 15, 2025

Choose a reason for hiding this comment

greptile-apps bot Apr 15, 2025

Choose a reason for hiding this comment

greptile-apps bot Apr 15, 2025

Choose a reason for hiding this comment

greptile-apps bot Apr 15, 2025

Choose a reason for hiding this comment

greptile-apps bot Apr 15, 2025

Choose a reason for hiding this comment

greptile-apps bot Apr 15, 2025

Choose a reason for hiding this comment

greptile-apps bot Apr 15, 2025

Choose a reason for hiding this comment

posthog-bot commented Apr 16, 2025

📸 UI snapshots have been updated

benjackwhite Apr 16, 2025

Choose a reason for hiding this comment

benjackwhite Apr 16, 2025

Choose a reason for hiding this comment

havenbarnes Apr 16, 2025

Choose a reason for hiding this comment

posthog-bot commented Apr 17, 2025

📸 UI snapshots have been updated

havenbarnes commented Apr 3, 2025 •

edited

Loading