chore: allow all surveys to be repeated #30782
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces support for the "Always" schedule, enabling all surveys to be repeated, and adds a warning for potential over-display in popover surveys.
- /frontend/src/scenes/surveys/SurveyRepeatSchedule.tsx: Added conditional rendering of a warning banner for popover surveys when "Always" is selected and updated reset logic for iteration fields.
- /frontend/src/scenes/surveys/SurveyWidgetCustomization.tsx: Modified the checkbox toggle to set survey schedule to "Always" on selection, while resetting iteration_count and iteration_frequency_days to 0.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: +49 B (0%) Total Size: 13.2 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
I think we may also want to update the info tip here. |
|
@lucasheriques something to consider here is the breaking change. this might be undesired for customers with this setting |
|
@ioannisj fort he tooltip I agree, but need to first merge the posthog-js part to know the version @marandaneto currently the |
Exactly, and after the JS SDK change will be for all surveys, which is a breaking change, it will be appearing for all surveys instead of only widget surveys which is not what people intended when enabled this feature, or did i misunderstand that? |
|
@marandaneto yes, once/if we go forward if these JS SDK changes, this schedule will be available for all surveys. But, right now we're still restricting it to only widget surveys on our UI, so there are no other cases of surveys with the |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
lucasheriques
deleted the
chore/allow-every-survey-to-be-repeated-multiple-times
branch
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Problem
we've heard feedback of people wanting to test surveys but being hard to do, since a survey is only able to show once - except for feedback surveys.
This PR changes it allowing all surveys to have the schedule
always.needs PostHog/posthog-js#1866
Changes
I added banner for popover surveys, since there's a potential issue of a banner happening multiple times.
survey with waiting period:
survey with no waiting period and any display conditions:
survey with no display conditions at all:
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?