chore(insights): convert mocks from filters to query #30758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
force-pushed
the
convert-insight-mocks
branch
from
7d57364 to
ed3d096
Compare
thmsobrmlr
force-pushed
the
convert-insight-mocks
branch
from
b2391f8 to
fe76618
Compare
thmsobrmlr
commented
Apr 4, 2025
| @@ -15,7 +13,9 @@ import { | |||
| PersonsNode, | |||
| QueryStatus, | |||
| RefreshType, | |||
| } from './schema' | |||
| } from '~/queries/schema/schema-general' | |||
There was a problem hiding this comment.
This is unrelated to the actual changes here and just gets rid of an error message related to the import.
|
Size Change: -192 B (0%) Total Size: 13.1 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated14 snapshot changes in total. 0 added, 14 modified, 0 deleted:
Triggered by this commit. |
thmsobrmlr
commented
Apr 8, 2025
There was a problem hiding this comment.
I removed a card that display an error state, that isn't possible any more.
There was a problem hiding this comment.
The insight table stories were broken before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Insights now user queries exclusively, but the mocks are still using legacy filters.
Changes
Updates them
How did you test this code?
Visual regression tests