chore: Change redirect notification from toast to modal #30747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR replaces the toast-based redirect notification with a modal dialog in the authentication redirect flow.
- Updated
/frontend/src/scenes/authentication/redirectToLoggedInInstance.tsto import and useLemonModalfor notifications. - The modal includes explicit "Continue" and "Cancel" actions, with the primary triggering a redirect.
- The modal’s onClose callback unconditionally redirects, which may conflict with cancelling actions.
- Uses dynamic import for the modal to handle asynchronous loading.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/src/scenes/authentication/redirectToLoggedInInstance.ts
Outdated
Show resolved
Hide resolved
|
Working on this now. |
|
@Twixes feel free to give this a review. I didn't set an automatic count down with a redirect but we could. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: -10 B (0%) Total Size: 13.4 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
6 tasks
Twixes
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Discussion: https://posthog.slack.com/archives/C01FHN8DNN6/p1743590167887249
The redirect toast is being missed. We should change it to a modal instead. I think this does that, but has the usual 'Joe is a shit coder who is just trying his best, just be glad this isn't in zapfino' caveats on it.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?