Skip to content

Conversation

hpouillot
Copy link
Contributor

Changes

  • Do not show checked status on issue loading

Screenshot 2025-03-31 at 12 07 58

@hpouillot hpouillot requested a review from daibhin March 31, 2025 10:08
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes the checkbox behavior in the error tracking scene and streamlines type casting for aggregations.

• In /frontend/src/scenes/error-tracking/ErrorTrackingScene.tsx, the header checkbox now only shows checked when issues are loaded and selected.
• Removed redundant type casting in the CountColumn, improving code simplicity and type safety.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@daibhin daibhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha YES! This really bothered me but not enough that I was willing to find where it needing fixing

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 5)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 5)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

Size Change: -6 B (0%)

Total Size: 9.96 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 9.96 MB -6 B (0%)

compressed-size-action

@hpouillot hpouillot merged commit 2fc5f5e into master Mar 31, 2025
112 checks passed
@hpouillot hpouillot deleted the err/fix-selection-checkbox branch March 31, 2025 12:43
meikelmosby pushed a commit that referenced this pull request Mar 31, 2025
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants