Skip to content

feat(cdp): add opt_in_site_apps config flag warning #30550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MarconLP
Copy link
Member

Changes

  • Adds a dismissible warning to set the opt_in_site_apps flag.

2025-03-28 at 15 01 54

I tried to replicate the VersionCheck logic, but I don't want to send the siteAppsEnabledStatus with every event.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@MarconLP MarconLP requested a review from a team March 28, 2025 14:04
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds a dismissible warning to the HogFunctionConfiguration component for 'site_destination' configurations without an id, reminding users to enable the opt_in_site_apps flag.

  • Updated /frontend/src/scenes/pipeline/hogfunctions/HogFunctionConfiguration.tsx to conditionally render a warning banner when type is 'site_destination' and id is absent.
  • Implements dismissible behavior via a dismissKey, consistent with existing warning patterns.
  • Provides a direct link to the docs for enabling the opt_in_site_apps configuration.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

github-actions bot commented Mar 28, 2025

Size Change: -9 B (0%)

Total Size: 9.96 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 9.96 MB -9 B (0%)

compressed-size-action

type="warning"
action={{
children: 'Check out the docs',
to: 'https://posthog.com/docs/cdp/destinations',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a page in the docs to actually explain this so we can link customers directly to it? this is rather unhelpful if this is not the page explaining what to do and why to do it.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@MarconLP MarconLP removed the stale label Apr 8, 2025
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants