feat(cdp): hide the filtered metric #30504
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR removes the 'filtered' metric from the CDP metrics display by updating both the UI configuration and API request parameters.
- Removed 'filtered' metric from
METRICS_INFOobject in/frontend/src/scenes/pipeline/metrics/AppMetricsV2.tsx - Added explicit metric names in API request params in
/frontend/src/scenes/pipeline/metrics/appMetricsV2Logic.tsxto control which metrics are displayed - Visual confirmation shows clean removal of the metric from the UI display
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: -216 B (0%) Total Size: 10.2 MB ℹ️ View Unchanged
|
| @@ -20,6 +29,18 @@ const METRICS_INFO = { | |||
| 'Total number of events that were skipped due to the destination being permanently disabled (due to prolonged issues with the destination)', | |||
| } | |||
|
|
|||
| const ALL_METRIC_TYPES = [ | |||
There was a problem hiding this comment.
So i just checked it out locally and for me this is the experience:
- If i dont have anything selected it still shows me succeeded
- succeeded is always shown so if i only want to see the graph for filtered and e.g. failed i cannot do that
- i don't know if it should be part of this PR but when I select a time-window the upper element that is showing the absolut numbers is not updating (i assume its always showing the total amount)
- transformations and destinations have the same metric types although thats not true, right? Transformations do not support fetch for example
There was a problem hiding this comment.
If i dont have anything selected it still shows me succeeded
I wasn't able to replicate this issue. Is that still happening?
i don't know if it should be part of this PR but when I select a time-window the upper element that is showing the absolut numbers is not updating (i assume its always showing the total amount)
Fixed this issue
transformations and destinations have the same metric types although thats not true, right? Transformations do not support fetch for example
Filtered out the fetch metric for transformations
There was a problem hiding this comment.
i'm using Arc btw if that helps.
There was a problem hiding this comment.
Found the issue and pushed a fix
1cd26e1 (#30504)
| <LemonDropdown | ||
| closeOnClickInside={false} | ||
| matchWidth={false} | ||
| placement="right-end" |
There was a problem hiding this comment.
- right-end leads to looking inconsistant with the rest of the UI
- clicking on the actual check-box does not work but only on the list item
There was a problem hiding this comment.
right-end leads to looking inconsistant with the rest of the UI
clicking on the actual check-box does not work but only on the list item
Moved the checkboxes to the left side and fixed the click issue
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
The
filteredmetric shouldn't be shown.Changes
filteredmetric by defaultDoes this work well for both Cloud and self-hosted?
How did you test this code?