-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: add some merch links in the customization menu #30077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added a new 'Customization IRL' section to the user customization settings menu, providing a direct link to PostHog's merchandise store (merch.posthog.com).
- Added new setting entry in
frontend/src/scenes/settings/SettingsMap.tsx
under user customization with proper security attributes for external link - Simple implementation that maintains existing settings structure while adding a new way to discover PostHog merchandise
💡 (5/5) You can turn off certain types of comments like style here!
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why you tagged me :D More for the website folks to decide if this is fine but I'm happy with it sure :D
Tagged you just because it was recommended by GitHub and wasn't sure who else to nag 😂 I posted in Dev at the time, but if this is a W&V team thing then I'll tag them too while the branch updates. |
@@ -380,7 +380,7 @@ export const SETTINGS_MAP: SettingSection[] = [ | |||
id: 'core-memory', | |||
title: 'Memory', | |||
description: | |||
'Max automatically remembers details about your company and product. This context helps our AI assistant provide relevant answers and suggestions. If there are any details you don’t want Max to remember, you can edit or remove them below.', | |||
'Max automatically remembers details about your company and product. This context helps our AI assistant provide relevant answers and suggestions. If there are any details you don't want Max to remember, you can edit or remove them below.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ' in don't needs to be escaped, like this 'I don\'t like JS strings'
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Size Change: +98 B (0%) Total Size: 13.2 MB ℹ️ View Unchanged
|
Problem
Small thing. Occurred to me we could tell people in the app about merch too, so I added a quick link to do that.
Still haven't been able to test this because, despite getting a new Mac, I haven't been able to build a local env.