Skip to content

feat(udfs): allow compiling udfs other than aggregate_funnel #29843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Mar 12, 2025

Problem

The UDF build process is setup just for the aggregate_funnel binary.

Changes

This PR makes the build process generic and allows building other binaries for usage in UDFs.

Details:

  • Made the build script executable: chmod +x ./build.sh.
  • Renamed the funnel_udfs folder to udfs and changed the directory structure to have a separate directory for each binary in src.
  • Configured Cargo.toml to build separate binaries.
  • Added a hello_world binary to test all this; should probably be removed before this is merge in.
  • Added a README.

How did you test this code?

@thmsobrmlr thmsobrmlr requested a review from aspicer March 12, 2025 17:45
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@posthog-bot
Copy link
Contributor

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

@thmsobrmlr thmsobrmlr removed the stale label Mar 27, 2025
@thmsobrmlr thmsobrmlr reopened this Mar 27, 2025
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@posthog-bot
Copy link
Contributor

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

@aspicer aspicer reopened this Apr 11, 2025
@aspicer
Copy link
Contributor

aspicer commented Apr 11, 2025

@thmsobrmlr let me know if you wanted to get this in. happy to review it or try it to build

@thmsobrmlr
Copy link
Contributor Author

@aspicer Yup, I'll update according to the new deployment workflow when I'm on support next week.

@thmsobrmlr thmsobrmlr removed the stale label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants