chore(): add eslint-plugin-react-google-translate to posthog app #27521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havenbarnes
changed the title
Contributor
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
frontend/src/scenes/feature-flags/FeatureFlagReleaseConditions.tsx
Outdated
Show resolved
Hide resolved
…posthog into eslint-google-translate
Contributor
📸 UI snapshots have been updated33 snapshot changes in total. 0 added, 33 modified, 0 deleted:
Triggered by this commit. |
havenbarnes
commented
Jan 14, 2025
Contributor
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
Contributor
📸 UI snapshots have been updated32 snapshot changes in total. 0 added, 32 modified, 0 deleted:
Triggered by this commit. |
frontend/__snapshots__/scenes-app-feature-flags--edit-feature-flag--light.png
Show resolved
Hide resolved
frontend/__snapshots__/scenes-app-feature-flags--edit-multi-variate-feature-flag--light.png
Show resolved
Hide resolved
frontend/__snapshots__/scenes-app-heatmaps--heatmaps-browser-with-page-selected--dark.png
Show resolved
Hide resolved
Contributor
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Contributor
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
…nt-google-translate
…posthog into eslint-google-translate
Contributor
Author
|
@rafaeelaudibert sorry for jumping the gun on re-review earlier, should be ready now |
rafaeelaudibert
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This eslint plugin warns against react patterns that can result in errors thrown when our users attempt to use our sites with google translate enabled (example of this here)
More info on the problem here: facebook/react#11538
I will likely also add this to posthog.com as there have been the same errors there experienced by prospective users as well
Changes
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Rendered changed frontend code to make sure no visual changes occur