fix: banner paddings

[joshsny]

Problem

Banners had no padding on raw layouts

Changes

• Add padding
• Remove unused app-canvas layout

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Looked at the banner

[github-actions]

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged

Filename	Size
frontend/dist/toolbar.js	1.11 MB

_{compressed-size-action}

[posthog-bot]

📸 UI snapshots have been updated

70 snapshot changes in total. 0 added, 70 modified, 0 deleted:

• chromium: 0 added, 70 modified, 0 deleted (diff for shard 1, diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[zlwaterfield]

I'll be honest, I don't fully understand how your change shifted these pages down but it is now properly fitted so it works for me.

The pages where the first content block is the tab component looks like the space is a bit too large because of the padding on the tab but just a minor thing. It only looks fine now because the page is incorrectly formatted.

Before:

After:

[joshsny]

@zlwaterfield Do you think it's worth fixing the padding issues by moving the logic down into the <ProjectNotice /> and <BillingAlertsV2 /> components? Right now this is rendering two divs of 0 height which is causing the layout change...

[zlwaterfield]

@zlwaterfield Do you think it's worth fixing the padding issues by moving the logic down into the <ProjectNotice /> and <BillingAlertsV2 /> components? Right now this is rendering two divs of 0 height which is causing the layout change...

Ah yeah that's a good point. Yeah because those components render null for many cases.

[joshsny]

@zlwaterfield updated to move the check down into the individual components. Not the prettiest, but get's the job done

[posthog-bot]

📸 UI snapshots have been updated

70 snapshot changes in total. 0 added, 70 modified, 0 deleted:

• chromium: 0 added, 70 modified, 0 deleted (diff for shard 1, diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[zlwaterfield]

Might need to pull this and merge locally. Just use snapshots from master and it will re-run and update them after you push.

[posthog-bot]

📸 UI snapshots have been updated

58 snapshot changes in total. 0 added, 58 modified, 0 deleted:

• chromium: 0 added, 58 modified, 0 deleted (diff for shard 1, diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.