Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(digest): send group id properly #27026

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

raquelmsmith
Copy link
Member

Problem

Customer.io rejected our periodic digest events because the group ID was missing.

Changes

Makes sure there is an organization ID on the event groups

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

added a test

@raquelmsmith raquelmsmith requested a review from a team December 18, 2024 20:28
Copy link

sentry-io bot commented Dec 18, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: posthog/tasks/usage_report.py

Function Unhandled Issue
capture_event AssertionError: group_key must have (<class 'numbers.Number'>, (<class 'str'>,), <class 'uuid.UUID'>), got: None ...
Event Count: 5.3k

Did you find this useful? React with a 👍 or 👎

@raquelmsmith raquelmsmith enabled auto-merge (squash) December 18, 2024 20:28
@raquelmsmith raquelmsmith changed the title fix(digest): send group id as string not uuid fix(digest): send group id properly Dec 18, 2024
@raquelmsmith raquelmsmith merged commit 7dd30e3 into master Dec 18, 2024
94 checks passed
@raquelmsmith raquelmsmith deleted the fix/digest-group-format branch December 18, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants