Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): toggle alert threshold lines #25700

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

anirudhpillai
Copy link
Contributor

Problem

Alert threshold lines were visible by default on the insight.

Changes

  • Adds option to let users toggle the threshold lines.
  • Fix bug to hide null thresholds
image image

Does this work well for both Cloud and self-hosted?

N/A

How did you test this code?

Tested locally

@anirudhpillai anirudhpillai requested a review from a team October 19, 2024 15:16
@anirudhpillai anirudhpillai enabled auto-merge (squash) October 19, 2024 15:24
Copy link
Contributor

github-actions bot commented Oct 19, 2024

Size Change: 0 B

Total Size: 1.14 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.14 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

@skoob13 skoob13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I would display threshold lines by default, but it's not a big deal.

@anirudhpillai anirudhpillai merged commit da6131f into master Oct 22, 2024
94 checks passed
@anirudhpillai anirudhpillai deleted the feat/alert-threshold-lines-toggle branch October 22, 2024 08:48
fuziontech added a commit that referenced this pull request Oct 22, 2024
* master:
  fix(replay-templates): show event selector button, diff mobile filter (#25739)
  feat(replay): add "what to watch" screen (#25717)
  fix(events): Fix PostHog property filtering (#25732)
  fix(api): Apply org/team key scoping more narrowly (#25634)
  feat(Experiments): UX feedback from private beta of no-code experiments. (#25694)
  fix: playlist should track current session id (#25730)
  chore(data-warehouse): Set the stripe version when listing objects (#25729)
  chore(data-warehouse): Added extra props for hubspot syncs (#25728)
  revert: perf: Speed up filtering persons pt 2 (#25731)
  chore(deps): Update posthog-js to 1.174.3 (#25724)
  perf: Speed up filtering persons pt 2 (#25718)
  feat(alerts): toggle alert threshold lines (#25700)
  feat: watch next and sort different (#25701)
  feat(cdp): add microsoft teams template (#25652)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants