-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerts): toggle alert threshold lines #25700
Conversation
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I would display threshold lines by default, but it's not a big deal.
* master: fix(replay-templates): show event selector button, diff mobile filter (#25739) feat(replay): add "what to watch" screen (#25717) fix(events): Fix PostHog property filtering (#25732) fix(api): Apply org/team key scoping more narrowly (#25634) feat(Experiments): UX feedback from private beta of no-code experiments. (#25694) fix: playlist should track current session id (#25730) chore(data-warehouse): Set the stripe version when listing objects (#25729) chore(data-warehouse): Added extra props for hubspot syncs (#25728) revert: perf: Speed up filtering persons pt 2 (#25731) chore(deps): Update posthog-js to 1.174.3 (#25724) perf: Speed up filtering persons pt 2 (#25718) feat(alerts): toggle alert threshold lines (#25700) feat: watch next and sort different (#25701) feat(cdp): add microsoft teams template (#25652)
Problem
Alert threshold lines were visible by default on the insight.
Changes
null
thresholdsDoes this work well for both Cloud and self-hosted?
N/A
How did you test this code?
Tested locally