chore: dependency wrangling #22829

pauldambra · 2024-06-09T20:24:07Z

1. I got fed up of seeing these warning

 WARN  deprecated @babel/plugin-proposal-class-properties@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.
 WARN  deprecated @babel/plugin-proposal-nullish-coalescing-operator@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-nullish-coalescing-operator instead.
 WARN  deprecated @babel/plugin-proposal-private-property-in-object@7.21.11: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-private-property-in-object instead.

so I obeyed them

2. turns out we have an eslint plugin for our jest tests but it wasn't actually running anything

so let's make it run

pauldambra · 2024-06-09T20:24:36Z

.eslintrc.js

@@ -60,7 +58,6 @@ module.exports = {
        'react/jsx-curly-brace-presence': ['error', { props: 'never', children: 'never', propElementValues: 'always' }],
        'no-console': ['error', { allow: ['warn', 'error'] }],
        'no-debugger': 'error',
-        'no-only-tests/no-only-tests': 'error',


built in to the jest plugin if you're actually using it

pauldambra · 2024-06-09T20:25:11Z

frontend/src/queries/nodes/DataNode/dataNodeLogic.queryCancellation.test.ts

@@ -46,39 +46,6 @@ describe('dataNodeLogic - query cancellation', () => {
    })
    afterEach(() => logic?.unmount())

-    it.skip('cancels a running query', async () => {


it's been skipped for a year, we don't need it

pauldambra · 2024-06-09T20:25:55Z

frontend/src/scenes/funnels/funnelDataLogic.test.ts

@@ -166,13 +166,6 @@ describe('funnelDataLogic', () => {

    describe('based on insightDataLogic', () => {
        describe('results', () => {
-            it.skip('with non-funnel insight', async () => {


it's been skipped for a year, we don't need it

pauldambra · 2024-06-09T20:26:02Z

frontend/src/scenes/insights/InsightNav/insightNavLogic.test.ts

@@ -245,29 +245,6 @@ describe('insightNavLogic', () => {
                })
            })

-            // it('stores series from retention entities', async () => {


it's been skipped for a year, we don't need it

pauldambra · 2024-06-09T20:26:25Z

frontend/src/scenes/insights/insightLogic.test.ts

@@ -304,7 +302,7 @@ describe('insightLogic', () => {
        })
    })

-    describe.skip('as dashboard item', () => {


it's been skipped for a year, only keep the tests that currently pass when unskipped

pauldambra · 2024-06-09T20:26:52Z

frontend/src/scenes/insights/insightSceneLogic.test.ts

@@ -42,8 +42,7 @@ describe('insightSceneLogic', () => {
            })
    })

-    // for some reason this test fails, while the tested behaviour is correct
-    it.skip('redirects when opening /insight/new with filters', async () => {


it doesn't fail for me 🤷

pauldambra · 2024-06-09T20:27:12Z

frontend/src/scenes/retention/retentionLineGraphLogic.test.ts

it's been skipped for a year, we don't need it

pauldambra · 2024-06-09T20:27:18Z

frontend/src/scenes/retention/retentionTableLogic.test.ts

it's been skipped for a year, we don't need it

pauldambra · 2024-06-09T20:27:34Z

frontend/src/scenes/session-recordings/player/sessionRecordingDataLogic.test.ts

@@ -378,47 +377,6 @@ describe('sessionRecordingDataLogic', () => {
                'loadSnapshotsForSourceSuccess',
            ])
        })
-
-        // regularly times out in CI, let's skip for now since we know this works 🙈
-        it.skip('polls up to a max threshold', async () => {


delete not skip!

pauldambra · 2024-06-09T20:28:00Z

package.json

        "esbuild-visualizer": "^0.6.0",
-        "eslint": "^8.52.0",
+        "eslint": "^8.57.0",


not every dependency we use yet supports eslint 9, so don't go there

posthog-bot · 2024-06-09T20:35:21Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

github-actions · 2024-06-09T20:44:55Z

Size Change: 0 B

Total Size: 1.06 MB

ℹ️ View Unchanged

Filename	Size
`frontend/dist/toolbar.js`	1.06 MB

_{compressed-size-action}

posthog-bot · 2024-06-09T20:46:32Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-09T20:56:34Z

📸 UI snapshots have been updated

5 snapshot changes in total. 0 added, 5 modified, 0 deleted:

chromium: 0 added, 5 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-09T21:08:18Z

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

chromium: 0 added, 4 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-09T21:19:32Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-09T21:29:59Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-09T21:41:34Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-09T21:53:27Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-09T22:03:57Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-09T22:14:28Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-09T22:24:55Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

pauldambra added 3 commits June 9, 2024 20:27

chore: dependency wrangling

07db033

update cypress dependencies

2f68798

jest linting

991c9eb

pauldambra commented Jun 9, 2024

View reviewed changes

frontend/src/scenes/retention/retentionLineGraphLogic.test.ts Outdated

Copy link

Member Author

pauldambra Jun 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's been skipped for a year, we don't need it

pauldambra commented Jun 9, 2024

View reviewed changes

frontend/src/scenes/retention/retentionTableLogic.test.ts Outdated

Copy link

Member Author

pauldambra Jun 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's been skipped for a year, we don't need it

pauldambra commented Jun 9, 2024

View reviewed changes

pauldambra requested a review from a team June 9, 2024 20:28

pauldambra marked this pull request as ready for review June 9, 2024 20:28

pauldambra and others added 3 commits June 9, 2024 21:31

fix

8637156

Update UI snapshots for chromium (1)

bf08c32

Update UI snapshots for chromium (2)

d176222

Update UI snapshots for chromium (2)

44ee6ee

github-actions bot added 2 commits June 9, 2024 20:55

Update UI snapshots for chromium (1)

b861fe8

Update UI snapshots for chromium (2)

d1469a3

github-actions bot added 2 commits June 9, 2024 21:06

Update UI snapshots for chromium (1)

9b549e1

Update UI snapshots for chromium (2)

b18f22a

github-actions bot added 2 commits June 9, 2024 21:17

Update UI snapshots for chromium (1)

c5dfaf2

Update UI snapshots for chromium (2)

e6326c1

Update UI snapshots for chromium (2)

114df6a

Update UI snapshots for chromium (2)

25d93ab

Update UI snapshots for chromium (2)

7743c70

Update UI snapshots for chromium (2)

acda0c5

Update UI snapshots for chromium (2)

07db9da

Update UI snapshots for chromium (2)

e835136

daibhin approved these changes Jun 10, 2024

View reviewed changes

pauldambra merged commit 4e657b4 into master Jun 10, 2024
85 checks passed

pauldambra deleted the chore/dependency-wrangling branch June 10, 2024 08:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: dependency wrangling #22829

chore: dependency wrangling #22829

pauldambra commented Jun 9, 2024

pauldambra Jun 9, 2024

pauldambra Jun 9, 2024

pauldambra Jun 9, 2024

pauldambra Jun 9, 2024

pauldambra Jun 9, 2024

pauldambra Jun 9, 2024

pauldambra Jun 9, 2024

pauldambra Jun 9, 2024

pauldambra Jun 9, 2024

pauldambra Jun 9, 2024

posthog-bot commented Jun 9, 2024

github-actions bot commented Jun 9, 2024 •

edited

Loading

posthog-bot commented Jun 9, 2024

posthog-bot commented Jun 9, 2024

posthog-bot commented Jun 9, 2024

posthog-bot commented Jun 9, 2024

posthog-bot commented Jun 9, 2024

posthog-bot commented Jun 9, 2024

posthog-bot commented Jun 9, 2024

posthog-bot commented Jun 9, 2024

posthog-bot commented Jun 9, 2024

posthog-bot commented Jun 9, 2024

chore: dependency wrangling #22829

chore: dependency wrangling #22829

Conversation

pauldambra commented Jun 9, 2024

1. I got fed up of seeing these warning

2. turns out we have an eslint plugin for our jest tests but it wasn't actually running anything

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

posthog-bot commented Jun 9, 2024

📸 UI snapshots have been updated

github-actions bot commented Jun 9, 2024 • edited Loading

posthog-bot commented Jun 9, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 9, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 9, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 9, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 9, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 9, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 9, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 9, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 9, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 9, 2024

📸 UI snapshots have been updated

github-actions bot commented Jun 9, 2024 •

edited

Loading