Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove the duplicate port config for temporal containers #20836

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix: remove the duplicate port config for temporal containers #20836

merged 1 commit into from
Mar 11, 2024

Conversation

zlwaterfield
Copy link
Contributor

@zlwaterfield zlwaterfield commented Mar 11, 2024 •
edited
Loading

Problem

I ran into this when running the repo locally:

Ports are not available: exposing port TCP 0.0.0.0:7233 -> 0.0.0.0:0: listen tcp 0.0.0.0:7233: bind: address already in use

In the the Docker UI I could see it was trying to bind the same ports twice for the temporal and temporal-ui containers.

Changes

The fix was to remove the duplicate port config in the dev docker compose since the base already did it.

@zlwaterfield zlwaterfield self-assigned this Mar 11, 2024
@timgl timgl enabled auto-merge (squash) March 11, 2024 19:20
@timgl timgl merged commit b841c43 into master Mar 11, 2024
79 checks passed
@timgl timgl deleted the fix-docker-temporal-duplicate-port-config branch March 11, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl timgl approved these changes

@fuziontech fuziontech Awaiting requested review from fuziontech

Assignees

@zlwaterfield zlwaterfield

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zlwaterfield @timgl