feat(plugin-server): add KAFKA_CONSUMPTION_RDKAFKA_COOPERATIVE_REBALANCE which defaults to true, fix metrics for eager #17406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NCE which defaults to true, fix metrics for eager
bretthoerner
force-pushed
the
brett/rdkafka-part-metrics2
branch
from
ec01d7b to
3337bed
Compare
Thanks! Gonna line all of this up with an overflow rollout with Xavier tomorrow, hopefully. |
xvello
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to try eager rebalances for event ingestion.
Changes
Add KAFKA_CONSUMPTION_RDKAFKA_COOPERATIVE_REBALANCE (defaults to true so we don't break recordings).
Also fix metric calculcation.
How did you test this code?
CI and local.