chore: Python 3.10 #14360
Merged
chore: Python 3.10 #14360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance gains go brrr
Needed this bug to be fixed: python/mypy#13627 This also incidentally fixed the mypy bug in csv_exporter.py
tomasfarias
reviewed
Feb 22, 2023
runtime.txt
Outdated
| @@ -1 +1 @@ | |||
| python-3.9.16 | |||
| python-3.10.7 | |||
There was a problem hiding this comment.
Any reason why we are not on the latest 3.10 patch? 3.10.10 was released on Feb 8th.
There was a problem hiding this comment.
Miscellaneous bugfixes in the changelog from 3.10.7 to 3.10.10 as far as I can tell.
There was a problem hiding this comment.
Oops, no reason, just Google lied to me when I searched latest python version 😔
tomasfarias
approved these changes
Feb 22, 2023
|
@frankh 3.11 ? ⏲️ |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Performance gains go brrr
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?