Fix missing title and opaque background on /about page#18633
Draft
ivanagas wants to merge 5 commits into
Draft
Conversation
Render the frontmatter title as an h1 (it was queried but never used) and remove the bg-primary wrapper so the page inherits the standard translucent app background instead of an opaque one. Generated-By: PostHog Code Task-Id: bb026c56-24d9-4752-8a16-2da1015d7269
Contributor
Deploy preview
|
Contributor
Bundle reportTotal JS (gzip)6.73 MiB (+1.5 KiB / +0.0%) Largest changed named chunks
Eager graph (modules shipped in each entrypoint's initial chunks)
Largest modules in the
|
| Module | Size |
|---|---|
./src/data/mcp-tools.json |
840.2 KiB |
css ./node_modules/.pnpm/css-loader@5.2.7_webpack@5.101.3/node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[8].oneOf[1].use[1]!./node_modules/.pnpm/postcss-loader@4.3.0_postcss@8.5.6_webpack@5.101.3/node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[8].oneOf[1].use[2]!./src/styles/global.css |
738.7 KiB |
./src/components/Stickers/Stickers.tsx |
696.4 KiB |
./node_modules/.pnpm/@radix-ui+react-icons@1.3.2_react@18.3.1/node_modules/@radix-ui/react-icons/dist/react-icons.esm.js |
481.4 KiB |
./node_modules/.pnpm/rehype-raw@7.0.0/node_modules/rehype-raw/lib/index.js + 29 modules |
395.1 KiB |
./node_modules/.pnpm/@posthog+icons@0.36.6_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.cjs.js |
364.8 KiB |
./src/hooks/useCustomers.tsx + 54 modules |
355.1 KiB |
./node_modules/.pnpm/@posthog+icons@0.36.6_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
354.8 KiB |
./node_modules/.pnpm/react-markdown@8.0.7_@types+react@16.14.66_react@18.3.1/node_modules/react-markdown/lib/react-markdown.js + 88 modules |
351.4 KiB |
./node_modules/.pnpm/cloudinary-core@2.14.0_lodash@4.17.21/node_modules/cloudinary-core/cloudinary-core.js |
281.9 KiB |
./src/components/ProductComparisonTable/index.tsx + 120 modules |
278.6 KiB |
./src/components/SearchUI/index.tsx + 87 modules |
271.8 KiB |
./gatsby-browser.tsx + 45 modules |
248.0 KiB |
./node_modules/.pnpm/d3@7.9.0/node_modules/d3/src/index.js + 208 modules |
247.4 KiB |
./src/components/Pricing/PricingSlider/Slider.tsx + 87 modules |
239.9 KiB |
Eager-graph budgets are report-only until a baseline is established. Sizes are gzip of public/**/*.js; eager size is webpack module source bytes for the modules actually shipped in the entrypoint's initial chunks (post-tree-shake).
Render the frontmatter title inside the Letterhead component (next to the logo, on the same row as the "from the desk of James Hawkins" block) instead of as a standalone heading above the letterhead. Generated-By: PostHog Code Task-Id: bb026c56-24d9-4752-8a16-2da1015d7269
Make "We're here to help make your product self-driving" the letterhead title and remove the now-duplicate h2 from the content, replacing the stale "help you build successful products" frontmatter title. Generated-By: PostHog Code Task-Id: bb026c56-24d9-4752-8a16-2da1015d7269
Contributor
|
Vale prose linter → found 2 errors, 6 warnings, 0 suggestions in your markdown Full report → Copy the linter results into an LLM to batch-fix issues. Linter being weird? Update the rules!
|
| Line | Severity | Message | Rule |
|---|---|---|---|
| 50:21 | warning | 'ick' is a possible misspelling. | PostHogBase.Spelling |
| 92:57 | error | Hi, Andy here... use an en dash ( – ) with spaces. On Mac, holding down the Option and hyphen key will give you an en dash. | PostHogBase.EnDash |
| 96:151 | error | Hi, Andy here... use an en dash ( – ) with spaces. On Mac, holding down the Option and hyphen key will give you an en dash. | PostHogBase.EnDash |
| 135:1 | warning | 'Value-based pricing Usage-based pricing' heading should be in sentence case, and product names should be capitalized. | PostHogBase.SentenceCase |
| 166:82 | warning | 'Tulum' is a possible misspelling. | PostHogBase.Spelling |
| 174:18 | warning | 'Combinator' is a possible misspelling. | PostHogBase.Spelling |
| 180:4 | warning | 'So tl;dr:' heading should be in sentence case, and product names should be capitalized. | PostHogBase.SentenceCase |
| 180:7 | warning | Use 'TL;DR' instead of 'tl;dr'. | Vale.Terms |
The flex-col wrapper blockified the inline-block logo SVG (which has no intrinsic width) and stretched it to the full column width. Drop the flex wrapper so the logo keeps its natural size, with the title rendering as a block below it. Generated-By: PostHog Code Task-Id: bb026c56-24d9-4752-8a16-2da1015d7269
Drop the PostHog logo from the letterhead (and its now-unused imports), leaving the title beside the "from the desk of James Hawkins" block. Generated-By: PostHog Code Task-Id: bb026c56-24d9-4752-8a16-2da1015d7269
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The /about page ("Why PostHog") was missing its title and rendering with an opaque white background instead of the standard translucent app background.
titleas an<h1>— it was being queried in the GraphQL but never actually rendered.bg-primarywrapper<div>so the page inherits thedata-scheme="primary"translucent background from theEditortemplate (the opaquebg-primarywas the sole thing forcing the white look).Why: Reported in Slack — the page was visibly missing a title and had the wrong (white/opaque) background.
Screenshots to be verified in the Vercel preview build.
Checklist
vercel.jsonCreated with PostHog from a Slack thread