feat(flags): add $feature_flag_evaluated_at properties to $feature_flag_called events
#2603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Contributor
|
Size Change: +1.94 kB (+0.04%) Total Size: 5.1 MB
ℹ️ View Unchanged
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Additional Comments (3)
-
packages/browser/src/__tests__/featureflags.test.ts, line 1707-1817 (link)style: tests validate
requestIdbut missing tests for newevaluatedAtproperty. check that similar tests for$feature_flag_evaluated_atexist to match the pattern used for$feature_flag_request_id -
packages/node/src/__tests__/feature-flags.flags.spec.ts, line 165 (link)style: test validates
$feature_flag_request_idbut missing validation for new$feature_flag_evaluated_atproperty -
packages/core/src/__tests__/posthog.featureflags.spec.ts, line 619 (link)style: test validates
$feature_flag_request_idbut missing validation for new$feature_flag_evaluated_atproperty
6 files reviewed, 4 comments
marandaneto
reviewed
Nov 21, 2025
| } | ||
| quotaLimited?: string[] | ||
| requestId?: string | ||
| evaluatedAt?: number // Unix timestamp in milliseconds |
Contributor
Author
There was a problem hiding this comment.
yeah, since UTC epoch; I'll update the comment
marandaneto
approved these changes
Nov 21, 2025
dustinbyrne
approved these changes
Nov 24, 2025
lricoy
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See PostHog/posthog#41824 for context
Changes
All of the JS libraries that emit
$feature_flag_calledevents received this change.Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file