-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web experiments): Emit web_experiment_applied event and do not render experiments for bots #1443
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +15.5 kB (+0.55%) Total Size: 2.82 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable, easy to follow, nice tests – all good from me!
_is_bot(): boolean | undefined { | ||
if (navigator && this.instance) { | ||
return isLikelyBot(navigator, this.instance.config.custom_blocked_useragents) | ||
} else { | ||
return undefined | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useful!
Sorry for not reviewing earlier, this is looking good! |
Changes
className
withcss
which assigns the value of this field to thestyle
attribute of an HTML element.preview
an Experiment variant in the browser without deploying the experiment.Checklist