Cannot find module 'rrweb-snapshot' or its corresponding type declarations

[loremaps]

Hi,

I get the following error when trying to upgrade to a later version than v1.9.7

Error: node_modules/posthog-js/dist/module.d.ts:4:50 - error TS2307: Cannot find module 'rrweb-snapshot' or its corresponding type declarations.

4 import { MaskInputOptions, SlimDOMOptions } from 'rrweb-snapshot'

this is for an Angular 12 project

It looks related to this:

posthog-js/src/module.d.ts

Line 4 in 923e82d

import { MaskInputOptions, SlimDOMOptions } from 'rrweb-snapshot'

Should rrweb-snapshot be added to the dependencies?

FYI it works fine if I install rrweb-snapshot separately.

[Twixes]

Does this still happen on the latest version?

[loremaps]

Yes, it does for version v1.12.1

[novocaine]

👋 We are encountering the same issue while validating type definitions using tsc. We aren't currently using rrweb-snapshot or sentry (which types are also being loaded from).

We would prefer not to force our users to install those dependencies which we are not using just to get tsc to validate our project. Might we consider a different approach to re-exporting the types of other libraries in the posthog-js interface? Perhaps we can duplicate the types in posthog's module.d.ts?

[Twixes]

Hey! We released posthog-js 1.12.3 which should fix this for now by adding rrweb-snapshot to dev-only dependencies. Could you try it out and see if that works better for you?

[loremaps]

Hi @Twixes, the issue is still there for me. I created a small repo to reproduce it for your convenience.

So far the only solution that works for me is to install rrweb-snapshot and @sentry/types as devDependencies.

[novocaine]

Hi @Twixes, the issue is still there for me. I created a small repo to reproduce it for your convenience.

So far the only solution that works for me is to install rrweb-snapshot and @sentry/types as devDependencies.

We have the same problem. Adding the dependencies as dev only dependencies won't help, npm doesn't install the devDependencies of a project's transitive dependencies.

[Twixes]

@loremaps A reproducible example is fantastic, thank you!

@novocaine You are of course correct, devDependencies is the wrong lead here. Hence I created #265 that fixes the problem definitively.