included evaluated_at properties in $feature_flag_called events
#394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannisj
requested changes
Nov 21, 2025
Collaborator
ioannisj
left a comment
ioannisj
left a comment
There was a problem hiding this comment.
LG, but we need to implement storage.getInt() & storage.setInt() cause builds are failing
dmarticus
changed the title
evaluated_at properties in $feature_flag_called events
ioannisj
approved these changes
Dec 4, 2025
Collaborator
ioannisj
left a comment
ioannisj
left a comment
There was a problem hiding this comment.
LG, just a minor question for clarification
PostHog/PostHogStorage.swift
Outdated
Comment on lines
457
to
463
| } else if let dictValue = value as? [String: Any] { | ||
| if let intValue = dictValue[key.rawValue] as? Int { | ||
| return intValue | ||
| } else if let numberValue = dictValue[key.rawValue] as? NSNumber { | ||
| return numberValue.intValue | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Do we need this fallback logic on nested dictionary values with same keys, or can we simplify?
Contributor
Author
There was a problem hiding this comment.
oh yeah, this is kinda gross. I'll make it better.
marandaneto
reviewed
Dec 8, 2025
|
|
||
| - feat: include `evaluated_at` properties in `$feature_flag_called` events ([#394](https://github.com/PostHog/posthog-ios/pull/394)) | ||
|
|
||
| ## 3.36.0 - 2025-12-03 |
Member
There was a problem hiding this comment.
this wasnt released yet (under next), so wrong versioning and wrong date
marandaneto
reviewed
Dec 8, 2025
| @@ -1,5 +1,11 @@ | |||
| ## Next | |||
|
|
|||
| ## 3.37.0 - 2025-12-08 | |||
Member
There was a problem hiding this comment.
.36 and .37 ahould be .36 since its not released yet, both the date of the release, today?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
See PostHog/posthog#41824 for context
💚 How did you test it?
New unit tests
📝 Checklist