Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: iOS build issue #35

Merged
merged 6 commits into from
Jun 1, 2023
Merged

fix: iOS build issue #35

merged 6 commits into from
Jun 1, 2023

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Jun 1, 2023 •
edited
Loading

The recently added Feature flags support had a bug.

Closes #33
Closes #31

Changs

  • Fixes the bug
  • Adds a CI workflow for building the example repo to at least check that everything is correct

@benjackwhite benjackwhite marked this pull request as ready for review June 1, 2023 09:19
neilkakkar
neilkakkar approved these changes Jun 1, 2023
View reviewed changes
Copy link

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks! looks like code 👀

@benjackwhite benjackwhite merged commit 075a4a5 into master Jun 1, 2023
@benjackwhite benjackwhite deleted the fix/ff-issue branch June 1, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilkakkar neilkakkar neilkakkar approved these changes

@fuziontech fuziontech Awaiting requested review from fuziontech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@benjackwhite @neilkakkar