fix: allow changing person properties after identify

PostHog · Nov 12, 2024 · a5e6feb · a5e6feb
1 parent bd1ec53
commit a5e6feb
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 ## Next
 
+- fix: allow changing person properties after identify ([#204](https://github.com/PostHog/posthog-android/pull/204)) 
+
 ## 3.9.1 - 2024-11-11
 
 - recording: fix observation on multiple threads in layout/draw is not supported for compose ([#204](https://github.com/PostHog/posthog-android/pull/204))

diff --git a/posthog/src/main/java/com/posthog/PostHog.kt b/posthog/src/main/java/com/posthog/PostHog.kt
@@ -556,6 +556,8 @@ public class PostHog private constructor(
             config?.logger?.log("identify called with invalid anonymousId: $anonymousId.")
         }
 
+        var shouldReloadFlags = false
+
         if (previousDistinctId != distinctId && !isIdentified) {
             // this has to be set before capture since this flag will be read during the event
             // capture
@@ -578,14 +580,24 @@ public class PostHog private constructor(
                 config?.logger?.log("identify called with invalid former distinctId: $previousDistinctId.")
             }
             this.distinctId = distinctId
+            shouldReloadFlags = true
+        } else if (userProperties?.isNotEmpty() == true || userPropertiesSetOnce?.isNotEmpty() == true) {
+            capture(
+                "\$set",
+                distinctId = distinctId,
+                userProperties = userProperties,
+                userPropertiesSetOnce = userPropertiesSetOnce,
+            )
 
-            // only because of testing in isolation, this flag is always enabled
-            if (reloadFeatureFlags) {
-                reloadFeatureFlags()
-            }
+            shouldReloadFlags = true
         } else {
             config?.logger?.log("already identified with id: $distinctId.")
         }
+
+        // only because of testing in isolation, this flag(reloadFeatureFlags) is always enabled
+        if (shouldReloadFlags && reloadFeatureFlags) {
+            reloadFeatureFlags()
+        }
     }
 
     private fun hasPersonProcessing(): Boolean {