Support passing versions via build.psd1 #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #128 and a few related (undiscovered) bugs where parameters set in build.psd1 would not have worked, including: Target, Passthru, Version, SemVer, Prerelease, BuildMetadata
Contributor
|
All good I think. |
gaelcolas
approved these changes
Mar 16, 2024
Contributor
gaelcolas
left a comment
gaelcolas
left a comment
There was a problem hiding this comment.
Looks good.
Since you moved some of the SemVer sanitation into InitializeBuild, I'm not 100% sure all the cases are covered when the value is passed by parameters.
But I'm a bit tired and haven't looked at BuildModule's code for a long time...
I'll find out prettty quickly if it breaks anyway :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I don't think it's very likely that people would pass the version this way, unless they were generating build.psd1 in their build -- but our docs say you can set any parameter via build.psd1, and I don't see why this shouldn't work.