Skip to content

Default base_url for HTTP Client #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Default base_url for HTTP Client #403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions portkey_ai/api_resources/base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,11 @@ def __init__(
)

self.allHeaders = self._build_headers(create_model_instance(Options))
if http_client:
http_client.base_url = (
http_client.base_url if http_client.base_url != "" else self.base_url
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comparison http_client.base_url != \"\" may not correctly handle all cases where base_url is unset. HTTPX's base_url is a URL object, not a string, and when unset it defaults to an empty URL object (which doesn't equal an empty string). Consider using if not http_client.base_url or str(http_client.base_url) == \"\" for a more robust check.

Suggested change
http_client.base_url if http_client.base_url != "" else self.base_url
http_client.base_url if http_client.base_url and str(http_client.base_url) != "" else self.base_url

Copilot uses AI. Check for mistakes.
)

self._client = http_client or httpx.Client(
base_url=self.base_url,
headers={
Expand Down Expand Up @@ -895,6 +900,10 @@ def __init__(
)

self.allHeaders = self._build_headers(create_model_instance(Options))
if http_client:
http_client.base_url = (
http_client.base_url if http_client.base_url != "" else self.base_url
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comparison http_client.base_url != \"\" may not correctly handle all cases where base_url is unset. HTTPX's base_url is a URL object, not a string, and when unset it defaults to an empty URL object (which doesn't equal an empty string). Consider using if not http_client.base_url or str(http_client.base_url) == \"\" for a more robust check.

Suggested change
http_client.base_url if http_client.base_url != "" else self.base_url
http_client.base_url if (http_client.base_url and str(http_client.base_url) != "") else self.base_url

Copilot uses AI. Check for mistakes.
)
self._client = http_client or AsyncHttpxClientWrapper(
base_url=self.base_url,
headers={
Expand Down