Skip to content

Conversation

@TheBigStonk
Copy link
Contributor

BCheck Contributions

  • BCheck compiles and executes as expected
  • BCheck contains appropriate metadata (name, version, author, description and appropriate tags)
  • Only .bcheck files have been added or modified
  • BCheck is in the appropriate folder
  • PR contains single or limited number of BChecks (Multiple PRs are preferred)
  • BCheck attempts to minimize false positives

As shown, looks like it's working as expected. Can run up the POC environment for ya'll to test to if you want to confirm it's working
image
image

Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your submission.

The BCheck detection logic looks good, there's a couple of trivial changes needed then we're good to go.

Copy link
Contributor Author

@TheBigStonk TheBigStonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PortSwiggerWiener changes should address comments in updated commit

Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your changes and patience during the review process.

LGTM 👍

@Hannah-PortSwigger Hannah-PortSwigger merged commit 189a65d into PortSwigger:main Oct 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants