Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace Carbon with CoreFoundation and CoreServices #479

Merged
merged 1 commit into from
Feb 5, 2021
Merged

replace Carbon with CoreFoundation and CoreServices #479

merged 1 commit into from
Feb 5, 2021

Conversation

jmelas
Copy link
Contributor

@jmelas jmelas commented Jan 28, 2021

This PR is part of issue #218 .
It removes Carbon dependency and replaces it with CoreFoundation and CoreServices frameworks.

@Be-ing
Copy link
Collaborator

Be-ing commented Feb 2, 2021

I'm amused by your branch name 😆

@philburk philburk self-assigned this Feb 4, 2021
@philburk
Copy link
Collaborator

philburk commented Feb 4, 2021

Test on Mac

@RossBencina RossBencina self-requested a review February 4, 2021 01:38
RossBencina
RossBencina approved these changes Feb 4, 2021
View reviewed changes
Copy link
Collaborator

@RossBencina RossBencina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this provisionally -- based on us getting some third parties to confirm that these work (both the ./configure and cmake).

@Be-ing
Copy link
Collaborator

Be-ing commented Feb 4, 2021

I will test with Mixxx using #461 and downloading the dylib artifact from GitHub Actions.

@RossBencina RossBencina added this to the V19.7 milestone Feb 4, 2021
@Be-ing
Copy link
Collaborator

Be-ing commented Feb 4, 2021

I tested on macOS 10.13 and it works. ✔️

@philburk
Copy link
Collaborator

philburk commented Feb 5, 2021

I tested with cmake and configure on SDK 11.1 on Big Sur and they both compiled.

@philburk philburk merged commit dd857f6 into PortAudio:master Feb 5, 2021
@jmelas jmelas deleted the decarbonize branch February 11, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossBencina RossBencina RossBencina approved these changes

Assignees

@philburk philburk

Labels
None yet
Projects
None yet
Milestone
V19.7
Development

Successfully merging this pull request may close these issues.
4 participants
@jmelas @Be-ing @philburk @RossBencina