Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings should not expose fields #164

Closed
PoorRican opened this issue May 8, 2023 · 0 comments · Fixed by #176
Closed

Settings should not expose fields #164

PoorRican opened this issue May 8, 2023 · 0 comments · Fixed by #176

Comments

@PoorRican
Copy link
Owner

Once #24 has been implemented, neither Settings or GlobalConfig should expose any and all fields. Settings should implement setters and getters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
0.1.0-beta Release
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Group PoorRican/sensd
1 participant
@PoorRican