Added date_time history/items to Temporal properties #1423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljeub-pometry
approved these changes
Dec 21, 2023
Collaborator
ljeub-pometry
left a comment
ljeub-pometry
left a comment
There was a problem hiding this comment.
Looks good but we should add more descriptive errors in the future instead of just returning None
fabianmurariu
pushed a commit
that referenced
this pull request
May 21, 2024
added date_time history/items to Temporal properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added a histories_date_time function to the TemporalProps object
Added a history_date_time and items_date_time function to TemporalProp
Why are the changes needed?
We now have datetime objects being returns for all structural histories, seems odd to miss these out.
Does this PR introduce any user-facing change? If yes is this documented?
Yes, these have documentation and it will be reflected in the tutorial as well.
How was this patch tested?
New tests added.
Are there any further changes required?
Yes, but as a larger refactor of datetimes