Swap parameters in Math.Log(double a, double newBase) translation
#1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauxjpn
added a commit
to lauxjpn/Pomelo.EntityFrameworkCore.MySql
that referenced
this pull request
Mar 17, 2024
…omeloFoundation#1891) (cherry picked from commit 5ca0fa1)
lauxjpn
added a commit
to lauxjpn/Pomelo.EntityFrameworkCore.MySql
that referenced
this pull request
Mar 17, 2024
…omeloFoundation#1891) (cherry picked from commit 5ca0fa1)
This was referenced Mar 17, 2024
lauxjpn
added a commit
to lauxjpn/Pomelo.EntityFrameworkCore.MySql
that referenced
this pull request
Mar 17, 2024
…omeloFoundation#1891) (cherry picked from commit 5ca0fa1)
lauxjpn
added a commit
to lauxjpn/Pomelo.EntityFrameworkCore.MySql
that referenced
this pull request
Mar 17, 2024
…omeloFoundation#1891) (cherry picked from commit 5ca0fa1)
lauxjpn
added a commit
to lauxjpn/Pomelo.EntityFrameworkCore.MySql
that referenced
this pull request
Mar 17, 2024
…omeloFoundation#1891) (cherry picked from commit 5ca0fa1)
lauxjpn
added a commit
to lauxjpn/Pomelo.EntityFrameworkCore.MySql
that referenced
this pull request
Mar 17, 2024
* Swap parameters in `Math.Log(double a, double newBase)` translation. (PomeloFoundation#1891) (cherry picked from commit 5ca0fa1)
lauxjpn
added a commit
to lauxjpn/Pomelo.EntityFrameworkCore.MySql
that referenced
this pull request
Mar 17, 2024
* Swap parameters in `Math.Log(double a, double newBase)` translation. (PomeloFoundation#1891) (cherry picked from commit 5ca0fa1)
lauxjpn
added a commit
to lauxjpn/Pomelo.EntityFrameworkCore.MySql
that referenced
this pull request
Mar 17, 2024
* Swap parameters in `Math.Log(double a, double newBase)` translation. (PomeloFoundation#1891) (cherry picked from commit 5ca0fa1)
lauxjpn
added a commit
to lauxjpn/Pomelo.EntityFrameworkCore.MySql
that referenced
this pull request
Mar 17, 2024
* Swap parameters in `Math.Log(double a, double newBase)` translation. (PomeloFoundation#1891) (cherry picked from commit 5ca0fa1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .NET signature for
Math.Log(double a, double newBase)has the parameter order swapped when compared to MySQL's LOG(B,X).This was not caught by the EF Core Specification Tests, because by chance, the related tests return the same entities in both cases.
Fixes #1890