Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non ed25519 #47

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Ignore non ed25519 #47

merged 2 commits into from
Apr 16, 2024

Conversation

polymath-eric
Copy link
Collaborator

@polymath-eric polymath-eric commented Apr 15, 2024

Description

Prevents hashicorp vault from crashing when non ed25519 keys are present in the connected transit engine.

Breaking Changes

None

JIRA Link

DA-1103

Checklist

  • Updated the Readme.md (if required) ?

…ent a runtime crash

filter non ed25519 keys so polkadot utils do not error when trying to parse the key as an ss58
address

DA-1103
remove lodash from package.json. Note: lodash is still a transitive dependency
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@polymath-eric polymath-eric merged commit 291b63f into main Apr 16, 2024
4 checks passed
@polymath-eric polymath-eric deleted the ignore-non-ed25519 branch April 16, 2024 19:25
@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/hashicorp-vault-signing-manager@3.2.1 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/signing-manager-types@3.3.0 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/browser-extension-signing-manager@2.3.0 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/fireblocks-signing-manager@2.5.0 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/approval-signing-manager@3.3.0 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/local-signing-manager@3.3.0 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/walletconnect-signing-manager@1.0.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants