Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 support customClaim withouth scope #299

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

sansan
Copy link
Contributor

@sansan sansan commented Nov 8, 2024

JIRA Link

https://polymesh.atlassian.net/browse/DA-1208

Changelog / Description

  • updates sdk to 26.2.0-alpha.1
  • update logic to allow for CustomClaim to be without scope defined
  • uses latest SDK to allow to retrieve CustomClaim scopes for did if middleware is enabled

Checklist -

  • New Feature ?
  • Unit Test (if possible) ?

Copy link
Contributor

@prashantasdeveloper prashantasdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a nit comment to remove log, otherwise LGTM

src/identities/identities.controller.ts Outdated Show resolved Hide resolved
update sdk version to 26.2.0-alpha.1
Copy link

sonarcloud bot commented Nov 8, 2024

@sansan
Copy link
Contributor Author

sansan commented Nov 8, 2024

/fast-forward

@polymath-eric polymath-eric merged commit 596bd9d into alpha Nov 8, 2024
7 checks passed
@polymath-eric polymath-eric deleted the feat/DA-1208 branch November 8, 2024 12:54
@polymesh-bot
Copy link
Contributor

🎉 This PR is included in version 6.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants