Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Various docs/developer experience fixes #49

Merged
merged 7 commits into from
Jun 30, 2015
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
console.log a message if there is an incorrect combination of attributes
  • Loading branch information
jeffposnick committed Jun 30, 2015
commit a862dc5717295d1141bfa570761e534c4a2c2722
3 changes: 3 additions & 0 deletions platinum-sw-fetch.html
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@
};
if (this.path && this.handler) {
params.route = [this.path, this.handler, this.origin];
} else {
console.log('The following platinum-sw-fetch element will not have any effect. ' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.warn?

'Both the "path" and "handler" attributes must be set.', this);
}
resolve(params);
}.bind(this));
Expand Down
3 changes: 3 additions & 0 deletions platinum-sw-import-script.html
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@
var params = {};
if (this.href) {
params.importscript = this.href;
} else {
console.log('The following platinum-sw-import-script element will not have any effect. ' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warn?

'The "href" attribute must be set.', this);
}
resolve(params);
}.bind(this));
Expand Down