Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

restoreFocusOnClosed is a boolean with a default true value which cannot be set to false #101

@fejesjoco

Description

@fejesjoco

https://www.polymer-project.org/1.0/docs/devguide/properties#configuring-boolean-properties says:

For a Boolean property to be configurable from markup, it must default to false. If it defaults to true, you cannot set it to false from markup, since the presence of the attribute, with or without a value, equates to true. This is the standard behavior for attributes in the web platform.

But paper-menu-button contains this:

          restoreFocusOnClose: {
            type: Boolean,
            value: true
          },

The default should be false (and the logic could be negated so that it's named noRestoreFocusOnClose).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions