Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tools to support Node 10 #536

Merged
merged 4 commits into from
Jun 22, 2018
Merged

Update tools to support Node 10 #536

merged 4 commits into from
Jun 22, 2018

Conversation

usergenic
Copy link
Contributor

@usergenic usergenic commented Jun 22, 2018

.travis.yml

  • Run tests on Node 10 instead of 9. (10.5+ supported; 10.4.x and under have a broken fs.chmod() that doesn't play nice with the way we use Gulp.)

polymer-build

  • generateServiceWorker relies on Function.prototype.toString() to insert function source code into the template to produce service-worker.js. In Node 10, anonymous functions are emitted without the space between function keyword and the parentheses, whereas previously there was a space. Now the generator replaces /bfunction\(/ with function ( explicitly so that behavior is consistent (and also integration tests based on static fixtures work for both versions).
  • Converted new Buffer( calls to Buffer.from( as constructor deprecated in Node 10.

polymer-cli

  • /test/fixtures/build-with-preset/expected/es5-bundled/service-worker.js test fixture updated so that all anonymous functions use the same spacing around function keyword: function () { }

polyserve

  • Converted new Buffer( calls to Buffer.from( as constructor deprecated in Node 10.

Copy link
Member

@aomarks aomarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants