Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.travis.yml
fs.chmod()
that doesn't play nice with the way we use Gulp.)polymer-build
Function.prototype.toString()
to insert function source code into the template to produceservice-worker.js
. In Node 10, anonymous functions are emitted without the space betweenfunction
keyword and the parentheses, whereas previously there was a space. Now the generator replaces/bfunction\(/
withfunction (
explicitly so that behavior is consistent (and also integration tests based on static fixtures work for both versions).new Buffer(
calls toBuffer.from(
as constructor deprecated in Node 10.polymer-cli
/test/fixtures/build-with-preset/expected/es5-bundled/service-worker.js
test fixture updated so that all anonymous functions use the same spacing around function keyword:function () { }
polyserve
new Buffer(
calls toBuffer.from(
as constructor deprecated in Node 10.