Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlattenedNodesObserver: do not fail on node without children #4988

Merged
merged 1 commit into from
Dec 20, 2017
Merged

FlattenedNodesObserver: do not fail on node without children #4988

merged 1 commit into from
Dec 20, 2017

Conversation

limonte
Copy link
Contributor

@limonte limonte commented Dec 12, 2017 •
edited
Loading

Reference Issue

Fixes #4987

Description

Document doesn't have children in IE:

For comparison, Chrome:

@limonte limonte mentioned this pull request Dec 12, 2017
Closed
TimvdLippe
TimvdLippe suggested changes Dec 12, 2017
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a testcase that we can run to verify the original issue and make sure we do not regress.

@limonte limonte changed the title Check if nodeList is defined in _(un)listenSlots method of FlattenedNodesObserver FlattenedNodesObserver: do not fail on node without children Dec 18, 2017
@limonte
Copy link
Contributor Author

limonte commented Dec 18, 2017 •
edited
Loading

Please add a test case that we can run to verify the original issue and make sure we do not regress.

Added test which fails in IE11 without the if (this._target.children) check and passes with it. Please take a look @TimvdLippe

@limonte
Copy link
Contributor Author

limonte commented Dec 18, 2017 •
edited
Loading

Tests are failing in Firefox not because of this PR, there's something else broken.

@TimvdLippe
Copy link
Contributor

Yes I started a discussion about the test failures, will get back to that. In the mean time, @azakus could you run this branch on IE to confirm the issue is fixed? Sadly I don't have a Windows development machine to my disposal.

@dfreedm dfreedm self-assigned this Dec 19, 2017
@dfreedm
Copy link
Member

dfreedm commented Dec 19, 2017

Got stuck on webcomponents/template#29 for a bit, reviewing now

@dfreedm dfreedm merged commit b7bd545 into Polymer:master Dec 20, 2017
@limonte
Copy link
Contributor Author

limonte commented Dec 20, 2017 •
edited
Loading

Thanks @azakus! It would be great if we can have the patch release, a project deadline is near and the IE11 support is important for our customer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimvdLippe TimvdLippe TimvdLippe requested changes

@dfreedm dfreedm dfreedm approved these changes

Assignees

@dfreedm dfreedm

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@limonte @TimvdLippe @dfreedm @googlebot