Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectItems, selectAll, and tests #4705

Closed
wants to merge 1 commit into from

Conversation

Westbrook
Copy link
Contributor

Reference Issue

Fixes #3176
Fixes #3827

This relates to the 2.x version of this PR #4699.

These two PRs will allow me to fully address the changes needed for PolymerElements/iron-list#436.

@Westbrook
Copy link
Contributor Author

Any thoughts on this from the team? I'd be happy to make any changes to the code, comments, tests, or PR that would allow us to move forward with this. It seems like a good amount of people would also be happy for the addition, and it would it would be really helpful in the conversion to 2.0 that my team and I are working on.

@Westbrook
Copy link
Contributor Author

I know that there is very little 1.x work being done, but I did see the recent patch that went out and am seeing the <custom-style> work being back ported to there, does anyone have any thoughts as to whether we could get this on the docket for the release that has to come together for that? Possibly @TimvdLippe, who's been making amazing waves on the issues/PR scene?

@TimvdLippe
Copy link
Contributor

The <custom-style> changes were required to prevent an upcoming Chrome change to break Polymer websites. This PR targets new functionality, so depending if #4699 gets merged, we might merge this one. The reason we have not reviewed the PRs is because we have to quantify the benefit of shipping and maintaing the extra API. E.g. maybe it is possible already with element extension to implement this functionality. Probably this afternoon we can take a look and give you some feedback 😄

@TimvdLippe
Copy link
Contributor

Closing per #4699 (comment) Check out the JSBin over there 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants