New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move shadycss and webcomponentsjs from dev-deps to deps #4596

Closed

limonte wants to merge 1 commit into Polymer:master from limonte:patch-1

Contributor

limonte commented May 12, 2017 •

edited

Loading

First of all, thanks for taking some actions towards npm support, npm is a must in modern webdev.

In 6b6092e shadycss and webcomponentsjs were added to the wrong section, those should be in dependencies, not in devDependencies.

npm deps should be aligned with Bower deps and dependencies basically should be the same for both Bower and npm.

Related Bower configuration: https://github.com/Polymer/polymer/blob/master/bower.json#L22-L25


          Move shadycss and webcomponentsjs from dev-deps to deps

3cfe016

googlebot added the cla: yes label

kevinpschaaf requested a review from dfreedm

May 30, 2017 16:43

limonte closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels