Add support for ES2015 classes and extension #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2520 Supported Use Cases: 1. `class MyElement` 2. `class MyElement extends Polymer.Element` 3. `class MyElement extends Polymer.Extend('input')` 4. `class MyElement extends OtherPolymerElement` 5. `class MyElement extends Polymer.Extend('other-polymer-element')`
Drop chained prototype list, it is unnecessary Add test for 2nd-order extension of input element
| * Utility function for extending native elements and Polymer elements with | ||
| * ES2015 class syntax. | ||
| * | ||
| * `Polymer.Extend()` will |
There was a problem hiding this comment.
The name seems kinda general. Maybe ElementConstructor or something?
There was a problem hiding this comment.
Not a fan of the long function name
class XFoo extends Polymer.ElementConstructor('other-element')Make __extendsNativeElement hold the native element tag name, if any prototype extends a native element, it will have __extendsNativeElement set on it Use constructors "the right way" in the ES2015 test
|
LGTM |
sorvell
pushed a commit
that referenced
this pull request
Feb 9, 2016
Add support for ES2015 classes and extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supported Use Cases:
class MyElementclass MyElement extends Polymer.Elementclass MyElement extends Polymer.Extend('input')class MyElement extends OtherPolymerElementclass MyElement extends Polymer.Extend('other-polymer-element')Fixes #2520