Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8 shim class #1397

Merged
merged 7 commits into from
Apr 10, 2015
Merged

0.8 shim class #1397

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0c748c0
Correct shady-dom hooks for add/remove elements.
sorvell Apr 10, 2015
dd46b60
For perf, shim styling with classes. Attr shimming optionally available.
sorvell Apr 10, 2015
e38410d
Merge branch '0.8-preview' into 0.8-shim-class
sorvell Apr 10, 2015
0b4b24d
enable class bindings to emit shimmed styles.
sorvell Apr 10, 2015
e86bb64
Merge branch '0.8-preview' into 0.8-shim-class
sorvell Apr 10, 2015
ab5d8c9
Fixes #1394
sorvell Apr 10, 2015
89a2c0f
x-styling: slight factoring and comment
sorvell Apr 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
enable class bindings to emit shimmed styles.
  • Loading branch information
@sorvell
sorvell committed Apr 10, 2015
commit 0b4b24db5db8aec754b5f0496848e11f741c7975
12 changes: 6 additions & 6 deletions src/standard/effects.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,12 +197,12 @@
var property = info.property || info.name || 'textContent';
// TODO(sorvell): consider pre-processing this step so we don't need
// this lookup.
// if (info._class === undefined) {
// info._class = (property === 'class' || property === 'className');
// }
// if (info._class) {
// value = this._scopeElementClass(node, value);
// }
if (info._class === undefined) {
info._class = (property === 'class' || property === 'className');
}
if (info._class) {
value = this._scopeElementClass(node, value);
}
if (info.kind == 'attribute') {
this.serializeValueToAttribute(value, property, node);
} else {
Expand Down