Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undeclared variable exception in _distributeInsertionPoint. #1351

Merged

Conversation

icetraxx
Copy link

  • Fix children is an undefined variable in _distributeInsertionPoint.
    • This caused an exception to be thrown when you instantiate a polymer element that uses localdom without any distributed childNodes.
  • Removed trailing whitespace and removed unnecessary variable redeclarations.

…ger redeclare variables throughout shady..
@abi
Copy link

abi commented Mar 31, 2015

👍

@sorvell
Copy link
Contributor

sorvell commented Apr 1, 2015

LGTM...

It's unclear how this generated an exception (http://jsbin.com/tumubuligo/1/edit).

sorvell pushed a commit that referenced this pull request Apr 1, 2015
Fix undeclared variable exception in _distributeInsertionPoint.
@sorvell sorvell merged commit 0c96c5d into Polymer:0.8-preview Apr 1, 2015
@icetraxx icetraxx deleted the 0.8-shady-variable-declarations branch April 2, 2015 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants