Ensure dom-if moved into doc fragment is torn down. Fixes #3324

Polymer · Jan 23, 2016 · 6c4f5d5 · 6c4f5d5
1 parent 55b91b3
commit 6c4f5d5
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/lib/template/dom-if.html b/src/lib/template/dom-if.html
@@ -73,7 +73,7 @@
     },
 
     detached: function() {
-      if (!this.parentNode) {
+      if (!this.parentNode || this.parentNode.nodeType == Node.DOCUMENT_FRAGMENT_NODE) {
         this._teardownInstance();
       }
     },

diff --git a/test/unit/dom-if.html b/test/unit/dom-if.html
@@ -67,6 +67,10 @@
     </div>
   </div>
 
+  <div id="removalContainer">
+    <template is="dom-if" if id="toBeRemoved"><div id="shouldBeRemoved"></div></template>
+  </div>
+
   <script>
 
     suite('nested pre-configured dom-if', function() {
@@ -651,6 +655,16 @@
         });
       });
 
+      test('move into doc fragment', function(done) {
+        var el = shouldBeRemoved;
+        var frag = document.createDocumentFragment();
+        Polymer.dom(frag).appendChild(toBeRemoved);
+        setTimeout(function() {
+          assert.equal(el.parentNode, null);
+          done();
+        });
+      });
+
     });