This repository was archived by the owner on May 1, 2019. It is now read-only.
Fix several compilation errors with Typescript 2.2 #444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing the analyzer with
yarn
pulls in Typescript 2.2. This resulted in some compiler errors which I fixed all but one.In TS 2.2 operators are more thoroughly checked, most notably arithmetic expressions do not allow undefined or null. I fixed these errors.
The last compiler error is because
lib.es2017.d.ts
intypescript-analyzer.ts
pulls inlib.es2016.d.ts
which pulls inlib.es2015.d.ts
which pulls inlib.es2015.collection.d.ts
and that file has a definition ofMap<K,V>
. This definition forces the second argumentvalue
of to be non-null per this commit. I am not sure why the Typescript maintainers introduced this change, since on mastervalue
is allowed to beundefined
. Therefore I pinned the version of Typescript to 2.1.4 for now.