This repository was archived by the owner on May 29, 2019. It is now read-only.
Adds global filters docs for #571 #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #### Creating global filters | ||
|
|
||
| Let's create a filter for transforming the letters in any templated string | ||
| to uppercase. Once registered, we will be able to use it as follows: |
There was a problem hiding this comment.
Remove "Once registered, we will be able to use it as follows:"
|
Thanks for the feedback, Eric! |
| Filters you wish to use across multiple elements can be defined in script and | ||
| imported in at the top of your Polymer element after Polymer has loaded. E.g: | ||
|
|
||
| {% raw %} |
There was a problem hiding this comment.
Don't need raw, just a 4 space indent for the pretty printer
|
@ebidel think I managed to address your feedback. Did I miss anything? |
|
LGTM. Ready to merge? |
|
Ready when you are! |
ebidel
added a commit
that referenced
this pull request
Aug 4, 2014
Adds global filters docs for #571
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reviewer: @ebidel