Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Add 'flex' attribute to element in the 'layout attributes' page #567

Merged
merged 1 commit into from
Aug 1, 2014
Merged

Add 'flex' attribute to element in the 'layout attributes' page #567

merged 1 commit into from
Aug 1, 2014

Conversation

lucasloisp
Copy link

No description provided.

@ebidel
Copy link
Contributor

ebidel commented Jul 30, 2014

Why the change?

@arthurevans
Copy link

I had noticed this -- the text is incorrect here. It says, " to make "Gamma" 2x larger than "Beta" and "Alpha" 3x larger, use:"

But if you look at the example, Beta is less than 1/2 the size of Gamma, because it's size auto.

We could correct the description instead, but correcting the sample is easier.

@addyosmani
Copy link
Member

@lucasloisp thanks for the PR. For future ones, could you include a description of why the change is needed? It helps us understand your intentions :)

@lucasloisp
Copy link
Author

Sure. Sorry for the misunderstanding. That was my point. That Gamma wasn't 2x larger than Beta, it was actually smaller. I thought of changing the description, but believed it would better suit the purpose to make them all flex, plus following the previous example, where "Beta" does flex.
I'm still new to the world of open-source code, so thanks for the response anyways

@ebidel
Copy link
Contributor

ebidel commented Jul 31, 2014

Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide.

@lucasloisp lucasloisp changed the title Update layout-attrs.md Add 'flex' attribute to element in the 'layout attributes' page Jul 31, 2014
@lucasloisp
Copy link
Author

done
"Google Individual CLA
Thank you. Your CLA submission will be processed shortly."

@ebidel
Copy link
Contributor

ebidel commented Aug 1, 2014

Thanks for signing the CLA!

@ebidel ebidel added cla: yes and removed cla: no labels Aug 1, 2014
ebidel added a commit that referenced this pull request Aug 1, 2014
Add 'flex' attribute to element in the 'layout attributes' page
@ebidel ebidel merged commit 3cc979d into Polymer:master Aug 1, 2014
@lucasloisp lucasloisp deleted the patch-1 branch August 1, 2014 21:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants